Christian Lamparter
5cf00adf21
apm821xx: fix crash/panic related to SATA/SSD choice
Ticerex on the OpenWrt Forum reported a gnarly crash when
he was using Samsung 840 and 850 EVOs with his MyBook Live:
| BUG: Kernel NULL pointer dereference at 0x00000000
| Faulting instruction address: 0xc03ed4b8
| Oops: Kernel access of bad area, sig: 11 [#1]
| BE PAGE_SIZE=4K PowerPC 44x Platform
| CPU: 0 PID: 362 Comm: scsi_eh_1 Not tainted 5.4.163 #0
| NIP: c03ed4b8 LR: c03d27e8 CTR: c03ed36c
| REGS: cfa59950 TRAP: 0300 Not tainted (5.4.163)
| MSR: 00021000 <CE,ME> CR: 42000222 XER: 00000000
| DEAR: 00000000 ESR: 00000000
| GPR00: c03d27e8 cfa59a08 cfa55fe0 00000000 0fa46bc0 [...]
| [..]
| NIP [c03ed4b8] sata_dwc_qc_issue+0x14c/0x254
| LR [c03d27e8] ata_qc_issue+0x1c8/0x2dc
| Call Trace:
| [cfa59a08] [c003f4e0] __cancel_work_timer+0x124/0x194 (unreliable)
| [cfa59a78] [c03d27e8] ata_qc_issue+0x1c8/0x2dc
| [cfa59a98] [c03d2b3c] ata_exec_internal_sg+0x240/0x524
| [cfa59b08] [c03d2e98] ata_exec_internal+0x78/0xe0
| [cfa59b58] [c03d30fc] ata_read_log_page.part.38+0x1dc/0x204
| [cfa59bc8] [c03d324c] ata_identify_page_supported+0x68/0x130
| [...]
This turned out this is an issue with upstream changing
ATA_TAG_INTERNAL's value from 31 to 32 during 4.18 release.
Update "SATA_DWC_QCMD_MAX" to account for that.
Link: https://forum.openwrt.org/t/my-book-live-duo-reboot-loop/122464
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
(cherry picked from commit 5ac672cfab60e90ab8a0bf3491fa2a27619d22d6)
2022-03-26 21:26:07 +01:00
..
2022-03-26 21:26:07 +01:00
2021-05-26 23:36:40 +02:00
2021-09-13 18:49:15 +02:00
2021-04-11 16:54:22 +02:00
2021-06-08 22:50:32 +02:00
2021-07-19 22:47:17 +02:00
2022-03-26 19:09:17 +01:00
2022-03-06 20:55:26 +01:00
2021-03-17 23:38:46 +01:00
2021-12-13 18:21:25 +01:00
2022-02-12 19:41:39 +01:00
2022-03-14 08:51:02 +01:00
2021-10-02 16:05:34 +02:00
2022-03-26 21:26:07 +01:00
2021-04-11 16:54:22 +02:00
2022-02-12 19:41:39 +01:00
2022-02-28 15:21:32 +01:00
2021-09-13 15:24:35 +02:00
2022-01-15 22:49:28 +01:00
2022-03-06 20:55:26 +01:00
2021-02-10 15:47:18 +01:00
2022-02-12 19:41:39 +01:00
2021-07-13 22:19:23 +02:00
2022-03-24 09:40:12 +01:00
2021-02-10 15:47:23 +01:00
2022-02-12 19:41:39 +01:00
2022-02-12 19:41:39 +01:00
2021-04-11 16:54:22 +02:00
2022-03-06 20:55:26 +01:00
2021-03-17 21:24:22 +01:00
2022-03-23 12:52:20 +00:00
2021-12-12 20:08:17 +01:00
2021-09-24 12:29:22 +02:00
2022-03-24 09:40:12 +01:00
2021-04-11 16:54:22 +02:00
2021-02-10 15:47:18 +01:00
2022-03-10 23:32:59 +01:00
2021-04-11 16:54:22 +02:00
2021-02-10 15:47:18 +01:00